-
Notifications
You must be signed in to change notification settings - Fork 36
Revert "[DEVEX-222] Add built-in auto-serialization" #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
w1am
merged 1 commit into
DEVEX-185-Rebranding
from
revert-329-DEVEX-222-AutoSerialization
Feb 27, 2025
Merged
Revert "[DEVEX-222] Add built-in auto-serialization" #332
w1am
merged 1 commit into
DEVEX-185-Rebranding
from
revert-329-DEVEX-222-AutoSerialization
Feb 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 44607ea.
RagingKore
added a commit
that referenced
this pull request
Apr 23, 2025
* moved all files into EventStore.Client project * moved files into main project and deleted remaining empty projects dropped support for net6.0 and net7.0 added some helpers to fluentdocker playing around the idea of keeping the container on tests * Remove unused target frameworks and pass certificate in healthcheck * Tests * Rename test symbols * Test workflow * Testing something * More tests * Improve CI * Improve CI * Fixup * Publish actions * Temporarily disable Public actions * Fixup * Test warmup * [DEVEX-222] Add built-in auto-serialization (#329) * [DEVEX-222] Added configuration options for KurrentClientSettings Create method This should enable easier customisation like changing serializer settings. * [DEVEX-222] Added overloads of Append methods that take regular events They currently use dummy serialisation * [DEVEX-222] Added TryDeserialize method to ResolvedEvent Currently it's implemented in a dummy way * [DEVEX-222] Added first working, but not yet complete JSON built-in serialization It's not fully ready, as it has hardcoded schema serializer. Main question will be how much from schema registry I need to move here. * [DEVEX-222] Added autoserialization settings and removed serializer from ResolvedEvent Per @RagingKore suggestion it'll be better not to keep the reference to serializer in ResolvedEvent to keep the clear intention behind it. Now, the serializer is resolved from schema registry based on the auto-serialization settings. Made possible to register more than one serializer per content type. Currently it doesn't support more schema definition types. To be discussed how to include them later on. * [DEVEX-222] Made serialization settings to create specific serializers That will make resolution easier and give users ability to inject their own serializers implementation * [DEVEX-222] Added override of the serialization settings to Persistent Subscriptions * [DEVEX-222] Added serialization type and merged serialization into Serialization Context Previously we had DeserializationContext, but after consideration, it'll be better to merge those concepts to make easier customizations per operations (e.g. append, subscribe, etc.). * [DEVEX-222] Added message type name resolution strategy Refactored the code accordingly. It takes the full object instead of the limited number of parameters, as you may be using metadata to get parameters about clrtype. * [DEVEX-222] Refactored Event Type Mapper to not be responsible for resolution of CLR types * [DEVEX-222] Added automatic message clr type resolution * [DEVEX-222] Added metadata extensions to allow injecting type informations * [DEVEX-222] Made CLR type be resolved based on the message type metadata header * [DEVEX-222] Added the MessageTypeResolutionStrategyWrapper for caching resolved types * [DEVEX-222] Added MessageSerializationContext to pass additional information like category name * [DEVEX-222] Refactored SerializationContext into MessageSerializerWrapper to make clearer responsibilities Actually, it's just wrapping message serializer based on the client settings. * [DEVEX-222] Added message type maps registration * [DEVEX-222] Added helpers for custom type resolutions strategy Removed also obsolete SerializationSettings * [DEVEX-222] Replaced MessageSerializerWrapper usage with more generic IMessageSerializer There's no need to force all code to know about wrapper existence, it's okay to just create it during the setup. * [DEVEX-222] Made Message to be record instead of Struct * [DEVEX-222] Refactored new AppendToStreamAsync method to have simplified syntax Now they don't require all the fancy, but redundant in most cases Stream Positions, Directions, EventData etc. * [DEVEX-222] Refactored Reading events signatures to use options instead of parameters Thanks to that safe defaults are already provided * [DEVEX-222] Renamed MessageTypeResolutionStrategy to MessageTypeNamingStrategy * [DEVEX-222] Made old Read methods be wrapper of the new one, instead the other way round * [DEVEX-222] Added serialization configuration overrides Old append and read methods won't be doing default serialization by default. The new one will use auto-seriailization and allow to customize or disable it. * [DEVEX-222] Removed storing CLR type in metadata and moved it to message type name Now the FullTypeName is placed in the event type name. Not perfect but here it is. * [DEVEX-222] Added possibility to register types for category name Thanks to that they will be resolved automatically by the registered convention. Then user doesn't need to provide the string name by hand. Added MessageTypeNamingResolution context besides the MessageSerializationContext as it's orthogonal and just overlapping context. * [DEVEX-222] Added SubscribeToAllOptions and Subscription Listener This is a similar API as we already have in Java client, to simplify the handlers registration. * [DEVEX-222] Addes SubscribeToStreamOptions and applied it accordingly to subscirbe to all changes * [DEVEX-222] Renamed DeserializedEvent to Message in ResolvedEvent I think that in the longer term, this will make intention clearer * [DEVEX-222] Added persistent subscription litener and capability to customize serialization for Persistent Subscriptions * [DEVEX-222] Extended Serialization tests for Appends and Reads * [DEVEX-222] Added capability to automatically deserialize message metadata By default it'll try to resolve the TraceMetadata, it can be override with the general type or using custom resolution strategy. * [DEVEX-222] For unknown reason the reverse Enumerable.Reverse wasn't taken but Array.Reverse 🤷 * [DEVEX-222] Fixed type resolution to correclty find types by assembly * [DEVEX-222] Added tests for serialization compatibility between manual and automatic deserialization * [DEVEX-222] Added tests for appends with autoserialization * Revert "[DEVEX-222] Added tests for appends with autoserialization" This reverts commit 04e0685. I'm reverting it as old methods are wrappers for new ones, so the test scenarios are covered by the old test suite. * [DEVEX-222] Extended serialization test suite * [DEVEX-222] Added tests for auto-serialization in Catch-up subscriptions * [DEVEX-222] Added tests for auto-serialization in persistent subscriptions * [DEVEX-222] Added Expected prefix to StreamState and StreamRevision in AppendToStreamOptions * [DEVEX-222] Merged namespaces Fixed also XML docs comments * [DEVEX-222] Renamed NulloMessageSerializer to NullMesageSerializer * [DEVEX-222] Added AppendToStream methods that has expected stream revision as a parameter * [DEVEX-222] Added XML documentation for Serialization settings * [DEVEX-222] Added Unit tests * [DEVEX-222] Added tests for type resolution Used also two external assemlies - one that's loaded, - one that's never loaded. To double-check behaviour of loading types from different assemblies. * [DEVEX-222] Added SchemaRegistry tests * Revert "[DEVEX-222] Add built-in auto-serialization (#329)" (#332) This reverts commit 44607ea. * [DEVEX-222] Add built-in auto-serialization (#333) * [DEVEX-222] Added configuration options for KurrentClientSettings Create method This should enable easier customisation like changing serializer settings. * [DEVEX-222] Added overloads of Append methods that take regular events They currently use dummy serialisation * [DEVEX-222] Added TryDeserialize method to ResolvedEvent Currently it's implemented in a dummy way * [DEVEX-222] Added first working, but not yet complete JSON built-in serialization It's not fully ready, as it has hardcoded schema serializer. Main question will be how much from schema registry I need to move here. * [DEVEX-222] Added autoserialization settings and removed serializer from ResolvedEvent Per @RagingKore suggestion it'll be better not to keep the reference to serializer in ResolvedEvent to keep the clear intention behind it. Now, the serializer is resolved from schema registry based on the auto-serialization settings. Made possible to register more than one serializer per content type. Currently it doesn't support more schema definition types. To be discussed how to include them later on. * [DEVEX-222] Made serialization settings to create specific serializers That will make resolution easier and give users ability to inject their own serializers implementation * [DEVEX-222] Added override of the serialization settings to Persistent Subscriptions * [DEVEX-222] Added serialization type and merged serialization into Serialization Context Previously we had DeserializationContext, but after consideration, it'll be better to merge those concepts to make easier customizations per operations (e.g. append, subscribe, etc.). * [DEVEX-222] Added message type name resolution strategy Refactored the code accordingly. It takes the full object instead of the limited number of parameters, as you may be using metadata to get parameters about clrtype. * [DEVEX-222] Refactored Event Type Mapper to not be responsible for resolution of CLR types * [DEVEX-222] Added automatic message clr type resolution * [DEVEX-222] Added metadata extensions to allow injecting type informations * [DEVEX-222] Made CLR type be resolved based on the message type metadata header * [DEVEX-222] Added the MessageTypeResolutionStrategyWrapper for caching resolved types * [DEVEX-222] Added MessageSerializationContext to pass additional information like category name * [DEVEX-222] Refactored SerializationContext into MessageSerializerWrapper to make clearer responsibilities Actually, it's just wrapping message serializer based on the client settings. * [DEVEX-222] Added message type maps registration * [DEVEX-222] Added helpers for custom type resolutions strategy Removed also obsolete SerializationSettings * [DEVEX-222] Replaced MessageSerializerWrapper usage with more generic IMessageSerializer There's no need to force all code to know about wrapper existence, it's okay to just create it during the setup. * [DEVEX-222] Made Message to be record instead of Struct * [DEVEX-222] Refactored new AppendToStreamAsync method to have simplified syntax Now they don't require all the fancy, but redundant in most cases Stream Positions, Directions, EventData etc. * [DEVEX-222] Refactored Reading events signatures to use options instead of parameters Thanks to that safe defaults are already provided * [DEVEX-222] Renamed MessageTypeResolutionStrategy to MessageTypeNamingStrategy * [DEVEX-222] Made old Read methods be wrapper of the new one, instead the other way round * [DEVEX-222] Added serialization configuration overrides Old append and read methods won't be doing default serialization by default. The new one will use auto-seriailization and allow to customize or disable it. * [DEVEX-222] Removed storing CLR type in metadata and moved it to message type name Now the FullTypeName is placed in the event type name. Not perfect but here it is. * [DEVEX-222] Added possibility to register types for category name Thanks to that they will be resolved automatically by the registered convention. Then user doesn't need to provide the string name by hand. Added MessageTypeNamingResolution context besides the MessageSerializationContext as it's orthogonal and just overlapping context. * [DEVEX-222] Added SubscribeToAllOptions and Subscription Listener This is a similar API as we already have in Java client, to simplify the handlers registration. * [DEVEX-222] Addes SubscribeToStreamOptions and applied it accordingly to subscirbe to all changes * [DEVEX-222] Renamed DeserializedEvent to Message in ResolvedEvent I think that in the longer term, this will make intention clearer * [DEVEX-222] Added persistent subscription litener and capability to customize serialization for Persistent Subscriptions * [DEVEX-222] Extended Serialization tests for Appends and Reads * [DEVEX-222] Added capability to automatically deserialize message metadata By default it'll try to resolve the TraceMetadata, it can be override with the general type or using custom resolution strategy. * [DEVEX-222] For unknown reason the reverse Enumerable.Reverse wasn't taken but Array.Reverse 🤷 * [DEVEX-222] Fixed type resolution to correclty find types by assembly * [DEVEX-222] Added tests for serialization compatibility between manual and automatic deserialization * [DEVEX-222] Added tests for appends with autoserialization * Revert "[DEVEX-222] Added tests for appends with autoserialization" This reverts commit 04e0685. I'm reverting it as old methods are wrappers for new ones, so the test scenarios are covered by the old test suite. * [DEVEX-222] Extended serialization test suite * [DEVEX-222] Added tests for auto-serialization in Catch-up subscriptions * [DEVEX-222] Added tests for auto-serialization in persistent subscriptions * [DEVEX-222] Added Expected prefix to StreamState and StreamRevision in AppendToStreamOptions * [DEVEX-222] Merged namespaces Fixed also XML docs comments * [DEVEX-222] Renamed NulloMessageSerializer to NullMesageSerializer * [DEVEX-222] Added AppendToStream methods that has expected stream revision as a parameter * [DEVEX-222] Added XML documentation for Serialization settings * [DEVEX-222] Added Unit tests * [DEVEX-222] Added tests for type resolution Used also two external assemlies - one that's loaded, - one that's never loaded. To double-check behaviour of loading types from different assemblies. * [DEVEX-222] Added SchemaRegistry tests --------- Co-authored-by: Oskar Dudycz <[email protected]> * Rename namespaces (#335) * Rename namespaces * feat: add ability to manually dispatch publish workflow * chore: set tag prefix to `kurrent@` * chore: set minimum-major-minor to 1.0 * chore: change name to `Kurrent Inc` * disable minver * refactor: move ExpectedRevision to StreamState. (#337) * [DEVEX-185] Removed leftover folders that had KurrentDb instead of KurrentDB (#340) It seems that after conflicts when merging StreamRevision PR, the code before merging stayed as duplicated without capital B in KurrentDb. I checked by doing copying with override from those folders to the proper one, and there were no differences besides those stream revision changes, so it's safe to just remove them. * chore: update license and readme * [DEVEX-222] - Auto serialization feedback improvements (#338) * [DEVEX-222] Fixed the missing application of custom serialization setting in AppendToStreamAsync method * [DEVEX-222] Added stream state as a mandatory parameter in append to stream Added also override for raw event append that has options and made other methods obsolete. Introduced OperationOptions that compose default client operation settings plus credentials and deadlines. * [DEVEX-222] Ensured that metadata is serialized with auto-serialization as regular system metadata * [DEVEX-222] Adjusted samples to match the append api changes Added also factor for event data that's not requiring to provide id immediately * [DEVEX-222] Added MessageData type as an easier to use replacement for EventData, and better aligned with general usage of messages instead of just events * [DEVEX-222] Refactored setting stream metadata to use OperationOptions * [DEVEX-222] Added DeserializedData and DeserializedMessages extensions for read results That should be a middle ground without forcing people to use a regular ResolvedEvent if they don't want to * [DEVEX-222] Simplified the message serializer implementation Now serializer creates a derived serializer merging operation settings with default settings if needed. That allowed to hide internal details and there's no need to pass content type explicitly, as it's already in settings. Extended SchemaRegistry to provide wrapper methods to naming resolution context. Thanks to that MessageSerializer doesn't need to reference it internally. To make responsibilities clearer made also naming resolution context part of serializer context. * [DEVEX-222] Marked old Stream Metadata options as obsolete * [DEVEX-222] Made old Read methods obsolete and used the new ones in tests * [DEVEX-222] Made Read options nullable, to precisely know if user provided options or not * [DEVEX-222] Made the Read Options nullable and thanks to that smarter, so e.g. FromEnd assigns also backwards if it wasn't set * [DEVEX-222] Made old SetStreamMetadata and ConditionalAppend methods obsolete * [DEVEX-222] Added delete method with options * [DEVEX-222] Made old subscription methods obsolete and adjusted tests to use them * [DEVEX-222] Added Tombstone method with options and made the old obsolete * [DEVEX-222] Made all persistent subscription methods obsolete * [DEVEX-222] Added samples showcasing auto-serialization usage * [DEVEX-222] Reshaped type resolution strategy to take EventRecord instead of just raw string. That should enable current users to override their strategy if they used something more than just message type name from EventRecord. It needs to be EventRecord and not ResolvedEvent, as resolution happens before creating ResolvedEvent. * [DEVEX-222] Changed message type registration to allow multiple message type names mapping to the same CLR class * [DEVEX-222] Nested Message type mapping into settings object * [DEVEX-222] Added nested message type mapping * [DEVEX-222] Replaced clr type with clr type name in naming resolution Tha makes naming strategy focused on just mapping types back and forth and allowing to disable auto registration * chore: point workflows to kurrent-io docker images --------- Co-authored-by: William Chong <[email protected]> Co-authored-by: Oskar Dudycz <[email protected]> Co-authored-by: Yo Eight <[email protected]> Co-authored-by: Oskar Dudycz <[email protected]> Co-authored-by: Jason Mitchell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #329